Request package update & rate limit system expansion (#413)

* Initial rework of rework of requester - WIP

* Implementing and checking rate limits - WIP

* implemented coinbene rate limiting shenanigans

* add in remaining WIP

* fixy

* use authenticated rate limit

* drop ceiling as this can be done with a counter later

* add functionality to struct

* purge config options for rate limiting so as to keep things minimal

* prepare futures and swap rate limiting for implementation

* Address linter issues

* Addressed nits, fixed race

* fix linter issue

* remove global var as this was only setting when newrequester was called

* moved rate limit functionality into its own file

* Update Bitfinex with correct rate limit and test endpoints (WIP)

* finish off bitfinex adjustments

* fixes

* fix linter issues

* slowed rate for coinbasepro

* drop rate limit for huobi as the doc times have intermittent 429 issues.

* Set MACOSX_DEPLOYMENT_TARGET to remove linking warning

* Addr Thrasher nits

* Addr glorious nits

* unexport do request function

* fixed nitorinos

* Fixed something I missed

* move disabled rate limiter into loadexchange and use interface functionality

* Add temp quick fix

exchanges/alphapoint/alphapoint.go

@@ -8,11 +8,13 @@ import (
 	"net/http"
 	"strconv"
 	"strings"
+	"time"
 
 	"github.com/gorilla/websocket"
 	"github.com/thrasher-corp/gocryptotrader/common/crypto"
 	exchange "github.com/thrasher-corp/gocryptotrader/exchanges"
 	"github.com/thrasher-corp/gocryptotrader/exchanges/order"
+	"github.com/thrasher-corp/gocryptotrader/exchanges/request"
 )
 
 const (
@@ -37,9 +39,9 @@ const (
 	alphapointOpenOrders       = "GetAccountOpenOrders"
 	alphapointOrderFee         = "GetOrderFee"
 
-	// alphapoint rate times
-	alphapointAuthRate   = 500
-	alphapointUnauthRate = 500
+	// alphapoint rate limit
+	alphapointRateInterval = time.Minute * 10
+	alphapointRequestRate  = 500
 )
 
 // Alphapoint is the overarching type across the alphapoint package
@@ -518,16 +520,15 @@ func (a *Alphapoint) SendHTTPRequest(method, path string, data map[string]interf
 		return errors.New("unable to JSON request")
 	}
 
-	return a.SendPayload(method,
-		path,
-		headers,
-		bytes.NewBuffer(PayloadJSON),
-		result,
-		false,
-		false,
-		a.Verbose,
-		a.HTTPDebugging,
-		a.HTTPRecording)
+	return a.SendPayload(&request.Item{
+		Method:        method,
+		Path:          path,
+		Headers:       headers,
+		Body:          bytes.NewBuffer(PayloadJSON),
+		Result:        result,
+		Verbose:       a.Verbose,
+		HTTPDebugging: a.HTTPDebugging,
+		HTTPRecording: a.HTTPRecording})
 }
 
 // SendAuthenticatedHTTPRequest sends an authenticated request
@@ -553,14 +554,15 @@ func (a *Alphapoint) SendAuthenticatedHTTPRequest(method, path string, data map[
 		return errors.New("unable to JSON request")
 	}
 
-	return a.SendPayload(method,
-		path,
-		headers,
-		bytes.NewBuffer(PayloadJSON),
-		result,
-		true,
-		true,
-		a.Verbose,
-		a.HTTPDebugging,
-		a.HTTPRecording)
+	return a.SendPayload(&request.Item{
+		Method:        method,
+		Path:          path,
+		Headers:       headers,
+		Body:          bytes.NewBuffer(PayloadJSON),
+		Result:        result,
+		AuthRequest:   true,
+		NonceEnabled:  true,
+		Verbose:       a.Verbose,
+		HTTPDebugging: a.HTTPDebugging,
+		HTTPRecording: a.HTTPRecording})
 }

exchanges/alphapoint/alphapoint_wrapper.go

@@ -70,9 +70,8 @@ func (a *Alphapoint) SetDefaults() {
 	}
 
 	a.Requester = request.New(a.Name,
-		request.NewRateLimit(time.Minute*10, alphapointAuthRate),
-		request.NewRateLimit(time.Minute*10, alphapointUnauthRate),
-		common.NewHTTPClientWithTimeout(exchange.DefaultHTTPTimeout))
+		common.NewHTTPClientWithTimeout(exchange.DefaultHTTPTimeout),
+		nil)
 }
 
 // FetchTradablePairs returns a list of the exchanges tradable pairs