d0zingcat/gocryptotrader
1
0
Fork 0
mirror of https://github.com/d0zingcat/gocryptotrader.git synced 2026-06-04 15:10:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

context: Add authenticated HTTP credentials (#892)

Browse Source 
* gRPC: context overide

* exchanges: continue update

* exchange: Update context handling
*Add setter methods for API credentials
*Shift credentials functionality to its own file in exchanges package
*Add tests
*Refactor function DeployCredentialsToContext for library usage
*Add function to process credential metadata from API boundary to internal use context value.
*Add OTP rpc handling

* exchanges: reverts to old style in GetFeeByType, reverts some code I accidently deleted. Plus things and other. XD

* template: update

* exchanges: fix linter issues

* REMOVE THAT AWESOME NEW LINE!

* gct: fix some tests

* I cant spell :(

* exchanges/gctscript: fix more tests

* coinnut: fix tests

* Update exchanges/credentials.go

Co-authored-by: Scott <gloriousCode@users.noreply.github.com>

* Update exchanges/credentials.go

Co-authored-by: Scott <gloriousCode@users.noreply.github.com>

* Update exchanges/credentials.go

Co-authored-by: Scott <gloriousCode@users.noreply.github.com>

* Update exchanges/credentials.go

Co-authored-by: Scott <gloriousCode@users.noreply.github.com>

* Update exchanges/credentials.go

Co-authored-by: Scott <gloriousCode@users.noreply.github.com>

* glorious: nits

* exchanges/gctcli: stop applying empty credentials

* fix linters

* exchanges: add test

* rpceserver: actually check error for errors

* rpcserver: fix up tests

* Update exchanges/credentials.go

Co-authored-by: Scott <gloriousCode@users.noreply.github.com>

* exchanges/creds: move tests to corresponding files, add protection and segration for Credentials struct & ptr values

* exchanges/creds: allow subaccount to override default credentials via gRPC

* exchanges/credentials: don't return nil in GetCredentials

* creds: spelling

* exchanges: fix glorious NITS!

* credentials: Add in test and refactor IsEmpty method.

* credentials: change type positioning (glorious)

* exchange_template: Fix template changes

* DOCS: Refresh

* docs: fix spelling

* DOCS: fix alignment and add package

* DOCS: ALIGN!

Co-authored-by: Ryan O'Hara-Reid <ryan.oharareid@thrasher.io>
Co-authored-by: Scott <gloriousCode@users.noreply.github.com>
This commit is contained in:
Ryan O'Hara-Reid
2022-03-21 13:58:08 +11:00
committed by GitHub
parent 58b9f8b9ec
commit 09fa2f236a
122 changed files with 3006 additions and 2126 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
exchanges/exmo/exmo.go
View File

@@ -329,8 +329,9 @@ func (e *EXMO) SendHTTPRequest(ctx context.Context, endpoint exchange.URL, path
// SendAuthenticatedHTTPRequest sends an authenticated HTTP request
func (e *EXMO) SendAuthenticatedHTTPRequest(ctx context.Context, epath exchange.URL, method, endpoint string, vals url.Values, result interface{}) error {
if !e.AllowAuthenticatedRequest() {
return fmt.Errorf("%s %w", e.Name, exchange.ErrAuthenticatedRequestWithoutCredentialsSet)
creds, err := e.GetCredentials(ctx)
if err != nil {
return err
}
urlPath, err := e.API.Endpoints.GetURL(epath)
@@ -347,13 +348,13 @@ func (e *EXMO) SendAuthenticatedHTTPRequest(ctx context.Context, epath exchange.
payload := vals.Encode()
hash, err := crypto.GetHMAC(crypto.HashSHA512,
[]byte(payload),
[]byte(e.API.Credentials.Secret))
[]byte(creds.Secret))
if err != nil {
return nil, err
}
headers := make(map[string]string)
headers["Key"] = e.API.Credentials.Key
headers["Key"] = creds.Key
headers["Sign"] = crypto.HexEncodeToString(hash)
headers["Content-Type"] = "application/x-www-form-urlencoded"

6
exchanges/exmo/exmo_test.go
View File

@@ -47,9 +47,7 @@ func TestMain(m *testing.M) {
}
e.API.AuthenticatedSupport = true
e.API.Credentials.Key = APIKey
e.API.Credentials.Secret = APISecret
e.SetCredentials(APIKey, APISecret, "", "", "", "")
os.Exit(m.Run())
}
@@ -303,7 +301,7 @@ func TestGetOrderHistory(t *testing.T) {
// Any tests below this line have the ability to impact your orders on the exchange. Enable canManipulateRealOrders to run them
// ----------------------------------------------------------------------------------------------------------------------------
func areTestAPIKeysSet() bool {
return e.ValidateAPICredentials()
return e.ValidateAPICredentials(e.GetDefaultCredentials()) == nil
}
func TestSubmitOrder(t *testing.T) {

2
exchanges/exmo/exmo_wrapper.go
View File

@@ -620,7 +620,7 @@ func (e *EXMO) GetFeeByType(ctx context.Context, feeBuilder *exchange.FeeBuilder
if feeBuilder == nil {
return 0, fmt.Errorf("%T %w", feeBuilder, common.ErrNilPointer)
}
if !e.AllowAuthenticatedRequest() && // Todo check connection status
if !e.AreCredentialsValid(ctx) && // Todo check connection status
feeBuilder.FeeType == exchange.CryptocurrencyTradeFee {
feeBuilder.FeeType = exchange.OfflineTradeFee
}