exchanges/wrappers: Refactor fetch orderbook/ticker/account info funcs (#1440)

* acrost: Pull thread, examine

* fix tests

* linter

* fix_linter

* revert rm ctx param to limit breakages when merging usptream

* linter fix

* Add in priority update grouping so that tests pass

* Update cmd/exchange_wrapper_standards/exchange_wrapper_standards_test.go

Co-authored-by: Scott <gloriousCode@users.noreply.github.com>

* glorious nits

* fixed spelling

* whoopsie

* aanother whoops

* glorious: NITTERS!

* glorious: further nitters

* srry linter gods

* glorious: nits continued

* sub test p ara lel

* drop main t.Parallel

* fix whoops

* wrappertests: use context with cancel (test)

* linter: fix

* ensure primary execution

* kucoin test fix

* revert standards test changes and bypass non critical errors

* rm single override

* wrap exported error for accounts

* thrasher: nits ch name

* gk: nits

* gk: nits FetchTickerCached -> GetCachedTicker

* gk: nits rn FetchOrderbookCached -> GetCachedOrderbook

* gk: nits rn FetchAccountInfoCached -> GetCachedAccountInfo

* linter: fix

* gk: nits

* thrasher: nitters 1

* thrasher: nitters tmpls

* gk: nitter

---------

Co-authored-by: shazbert <ryan.oharareid@thrasher.io>
Co-authored-by: Scott <gloriousCode@users.noreply.github.com>

cmd/documentation/exchanges_templates/binance.tmpl

@@ -39,13 +39,13 @@ for i := range bot.Exchanges {
 // Public calls - wrapper functions
 
 // Fetches current ticker information
-tick, err := b.FetchTicker()
+tick, err := b.UpdateTicker(...)
 if err != nil {
 	// Handle error
 }
 
 // Fetches current orderbook information
-ob, err := b.FetchOrderbook()
+ob, err := b.UpdateOrderbook(...)
 if err != nil {
 	// Handle error
 }

cmd/documentation/exchanges_templates/binanceus.tmpl

@@ -39,13 +39,13 @@ for i := range bot.Exchanges {
 // Public calls - wrapper functions
 
 // Fetches current ticker information
-tick, err := b.FetchTicker()
+tick, err := b.UpdateTicker(...)
 if err != nil {
 	// Handle error
 }
 
 // Fetches current orderbook information
-ob, err := b.FetchOrderbook()
+ob, err := b.UpdateOrderbook(...)
 if err != nil {
 	// Handle error
 }

cmd/documentation/exchanges_templates/bitfinex.tmpl

@@ -39,13 +39,13 @@ for i := range bot.Exchanges {
 // Public calls - wrapper functions
 
 // Fetches current ticker information
-tick, err := b.FetchTicker()
+tick, err := b.UpdateTicker(...)
 if err != nil {
 	// Handle error
 }
 
 // Fetches current orderbook information
-ob, err := b.FetchOrderbook()
+ob, err := b.UpdateOrderbook(...)
 if err != nil {
 	// Handle error
 }

cmd/documentation/exchanges_templates/bitflyer.tmpl

@@ -38,13 +38,13 @@ for i := range bot.Exchanges {
 // Public calls - wrapper functions
 
 // Fetches current ticker information
-tick, err := b.FetchTicker()
+tick, err := b.UpdateTicker(...)
 if err != nil {
 	// Handle error
 }
 
 // Fetches current orderbook information
-ob, err := b.FetchOrderbook()
+ob, err := b.UpdateOrderbook(...)
 if err != nil {
 	// Handle error
 }

cmd/documentation/exchanges_templates/bithumb.tmpl

@@ -38,13 +38,13 @@ for i := range bot.Exchanges {
 // Public calls - wrapper functions
 
 // Fetches current ticker information
-tick, err := b.FetchTicker()
+tick, err := b.UpdateTicker(...)
 if err != nil {
 	// Handle error
 }
 
 // Fetches current orderbook information
-ob, err := b.FetchOrderbook()
+ob, err := b.UpdateOrderbook(...)
 if err != nil {
 	// Handle error
 }

cmd/documentation/exchanges_templates/bitmex.tmpl

@@ -38,13 +38,13 @@ for i := range bot.Exchanges {
 // Public calls - wrapper functions
 
 // Fetches current ticker information
-tick, err := b.FetchTicker()
+tick, err := b.UpdateTicker(...)
 if err != nil {
 	// Handle error
 }
 
 // Fetches current orderbook information
-ob, err := b.FetchOrderbook()
+ob, err := b.UpdateOrderbook(...)
 if err != nil {
 	// Handle error
 }

cmd/documentation/exchanges_templates/bitstamp.tmpl

@@ -39,13 +39,13 @@ for i := range bot.Exchanges {
 // Public calls - wrapper functions
 
 // Fetches current ticker information
-tick, err := b.FetchTicker()
+tick, err := b.UpdateTicker(...)
 if err != nil {
 	// Handle error
 }
 
 // Fetches current orderbook information
-ob, err := b.FetchOrderbook()
+ob, err := b.UpdateOrderbook(...)
 if err != nil {
 	// Handle error
 }

cmd/documentation/exchanges_templates/btcmarkets.tmpl

@@ -39,13 +39,13 @@ for i := range bot.Exchanges {
 // Public calls - wrapper functions
 
 // Fetches current ticker information
-tick, err := b.FetchTicker()
+tick, err := b.UpdateTicker(...)
 if err != nil {
 	// Handle error
 }
 
 // Fetches current orderbook information
-ob, err := b.FetchOrderbook()
+ob, err := b.UpdateOrderbook(...)
 if err != nil {
 	// Handle error
 }

cmd/documentation/exchanges_templates/btse.tmpl

@@ -39,13 +39,13 @@ for i := range bot.Exchanges {
 // Public calls - wrapper functions
 
 // Fetches current ticker information
-tick, err := b.FetchTicker()
+tick, err := b.UpdateTicker(...)
 if err != nil {
 	// Handle error
 }
 
 // Fetches current orderbook information
-ob, err := b.FetchOrderbook()
+ob, err := b.UpdateOrderbook(...)
 if err != nil {
 	// Handle error
 }

cmd/documentation/exchanges_templates/bybit.tmpl

@@ -39,13 +39,13 @@ for i := range bot.Exchanges {
 // Public calls - wrapper functions
 
 // Fetches current ticker information
-tick, err := b.FetchTicker()
+tick, err := b.UpdateTicker(...)
 if err != nil {
 	// Handle error
 }
 
 // Fetches current orderbook information
-ob, err := b.FetchOrderbook()
+ob, err := b.UpdateOrderbook(...)
 if err != nil {
 	// Handle error
 }

cmd/documentation/exchanges_templates/coinbasepro.tmpl

@@ -39,13 +39,13 @@ for i := range bot.Exchanges {
 // Public calls - wrapper functions
 
 // Fetches current ticker information
-tick, err := c.FetchTicker()
+tick, err := c.UpdateTicker(...)
 if err != nil {
 	// Handle error
 }
 
 // Fetches current orderbook information
-ob, err := c.FetchOrderbook()
+ob, err := c.UpdateOrderbook(...)
 if err != nil {
 	// Handle error
 }

cmd/documentation/exchanges_templates/coinut.tmpl

@@ -39,13 +39,13 @@ for i := range bot.Exchanges {
 // Public calls - wrapper functions
 
 // Fetches current ticker information
-tick, err := c.FetchTicker()
+tick, err := c.UpdateTicker(...)
 if err != nil {
 	// Handle error
 }
 
 // Fetches current orderbook information
-ob, err := c.FetchOrderbook()
+ob, err := c.UpdateOrderbook(...)
 if err != nil {
 	// Handle error
 }

cmd/documentation/exchanges_templates/deribit.tmpl

@@ -39,13 +39,13 @@ for i := range bot.Exchanges {
 // Public calls - wrapper functions
 
 // Fetches current ticker information
-tick, err := d.FetchTicker()
+tick, err := d.UpdateTicker(...)
 if err != nil {
 	// Handle error
 }
 
 // Fetches current orderbook information
-ob, err := d.FetchOrderbook()
+ob, err := d.UpdateOrderbook(...)
 if err != nil {
 	// Handle error
 }

cmd/documentation/exchanges_templates/exchanges_orderbook_readme.tmpl

@@ -16,7 +16,7 @@ exchange interface system set by exchange wrapper orderbook functions in
 Examples below:
 
 ```go
-ob, err := yobitExchange.FetchOrderbook()
+ob, err := yobitExchange.UpdateOrderbook(...)
 if err != nil {
 	// Handle error
 }

cmd/documentation/exchanges_templates/exchanges_ticker_readme.tmpl

@@ -17,7 +17,7 @@ exchange interface system set by exchange wrapper orderbook functions in
 Examples below:
 
 ```go
-tick, err := yobitExchange.FetchTicker()
+tick, err := yobitExchange.UpdateTicker(...)
 if err != nil {
 	// Handle error
 }

cmd/documentation/exchanges_templates/exmo.tmpl

@@ -38,13 +38,13 @@ for i := range bot.Exchanges {
 // Public calls - wrapper functions
 
 // Fetches current ticker information
-tick, err := e.FetchTicker()
+tick, err := e.UpdateTicker(...)
 if err != nil {
 	// Handle error
 }
 
 // Fetches current orderbook information
-ob, err := e.FetchOrderbook()
+ob, err := e.UpdateOrderbook(...)
 if err != nil {
 	// Handle error
 }

cmd/documentation/exchanges_templates/gateio.tmpl

@@ -38,13 +38,13 @@ for i := range bot.Exchanges {
 // Public calls - wrapper functions
 
 // Fetches current ticker information
-tick, err := g.FetchTicker()
+tick, err := g.UpdateTicker(...)
 if err != nil {
 	// Handle error
 }
 
 // Fetches current orderbook information
-ob, err := g.FetchOrderbook()
+ob, err := g.UpdateOrderbook(...)
 if err != nil {
 	// Handle error
 }

cmd/documentation/exchanges_templates/gemini.tmpl

@@ -38,13 +38,13 @@ for i := range bot.Exchanges {
 // Public calls - wrapper functions
 
 // Fetches current ticker information
-tick, err := g.FetchTicker()
+tick, err := g.UpdateTicker(...)
 if err != nil {
 	// Handle error
 }
 
 // Fetches current orderbook information
-ob, err := g.FetchOrderbook()
+ob, err := g.UpdateOrderbook(...)
 if err != nil {
 	// Handle error
 }

cmd/documentation/exchanges_templates/hitbtc.tmpl

@@ -39,13 +39,13 @@ for i := range bot.Exchanges {
 // Public calls - wrapper functions
 
 // Fetches current ticker information
-tick, err := h.FetchTicker()
+tick, err := h.UpdateTicker(...)
 if err != nil {
 	// Handle error
 }
 
 // Fetches current orderbook information
-ob, err := h.FetchOrderbook()
+ob, err := h.UpdateOrderbook(...)
 if err != nil {
 	// Handle error
 }

cmd/documentation/exchanges_templates/huobi.tmpl

@@ -38,13 +38,13 @@ for i := range bot.Exchanges {
 // Public calls - wrapper functions
 
 // Fetches current ticker information
-tick, err := h.FetchTicker()
+tick, err := h.UpdateTicker(...)
 if err != nil {
 	// Handle error
 }
 
 // Fetches current orderbook information
-ob, err := h.FetchOrderbook()
+ob, err := h.UpdateOrderbook(...)
 if err != nil {
 	// Handle error
 }

cmd/documentation/exchanges_templates/kraken.tmpl

@@ -38,13 +38,13 @@ for i := range bot.Exchanges {
 // Public calls - wrapper functions
 
 // Fetches current ticker information
-tick, err := k.FetchTicker()
+tick, err := k.UpdateTicker(...)
 if err != nil {
 	// Handle error
 }
 
 // Fetches current orderbook information
-ob, err := k.FetchOrderbook()
+ob, err := k.UpdateOrderbook(...)
 if err != nil {
 	// Handle error
 }

cmd/documentation/exchanges_templates/lbank.tmpl

@@ -38,13 +38,13 @@ for i := range Bot.Exchanges {
 // Public calls - wrapper functions
 
 // Fetches current ticker information
-tick, err := l.FetchTicker()
+tick, err := l.UpdateTicker(...)
 if err != nil {
 	// Handle error
 }
 
 // Fetches current orderbook information
-ob, err := l.FetchOrderbook()
+ob, err := l.UpdateOrderbook(...)
 if err != nil {
 	// Handle error
 }

cmd/documentation/exchanges_templates/okx.tmpl

@@ -39,13 +39,13 @@ for i := range bot.Exchanges {
 // Public calls - wrapper functions
 
 // Fetches current ticker information
-tick, err := ok.FetchTicker()
+tick, err := ok.UpdateTicker(...)
 if err != nil {
 	// Handle error
 }
 
 // Fetches current orderbook information
-ob, err := ok.FetchOrderbook()
+ob, err := ok.UpdateOrderbook(...)
 if err != nil {
 	// Handle error
 }

cmd/documentation/exchanges_templates/poloniex.tmpl

@@ -39,13 +39,13 @@ for i := range bot.Exchanges {
 // Public calls - wrapper functions
 
 // Fetches current ticker information
-tick, err := p.FetchTicker()
+tick, err := p.UpdateTicker(...)
 if err != nil {
 	// Handle error
 }
 
 // Fetches current orderbook information
-ob, err := p.FetchOrderbook()
+ob, err := p.UpdateOrderbook(...)
 if err != nil {
 	// Handle error
 }

cmd/documentation/exchanges_templates/yobit.tmpl

@@ -38,13 +38,13 @@ for i := range bot.Exchanges {
 // Public calls - wrapper functions
 
 // Fetches current ticker information
-tick, err := y.FetchTicker()
+tick, err := y.UpdateTicker(...)
 if err != nil {
 	// Handle error
 }
 
 // Fetches current orderbook information
-ob, err := y.FetchOrderbook()
+ob, err := y.UpdateOrderbook(...)
 if err != nil {
 	// Handle error
 }