CI/build: Update Go version, linters and fix minor issues (#1473)

* CI/build: Update Go version, linters and fix minor issues * Bump golangci-lint to v1.56.1 * BinanceUS: Make uint usage consistent * Throw blank identifiers into the trash
2026-06-06 23:16:53 +00:00 · 2024-02-14 11:02:06 +11:00
parent 9ff502bac2
commit 08da42ddb7
79 changed files with 364 additions and 374 deletions
--- a/exchanges/binanceus/binanceus.go
+++ b/exchanges/binanceus/binanceus.go
@@ -348,7 +348,7 @@ func (bi *Binanceus) GetOrderBookDepth(ctx context.Context, arg *OrderBookDataRe
 		return nil, err
 	}
 	params.Set("symbol", symbol)
-	params.Set("limit", fmt.Sprintf("%d", arg.Limit))
+	params.Set("limit", strconv.FormatInt(arg.Limit, 10))
 	var resp OrderBookData
 	if err := bi.SendHTTPRequest(ctx,
 		exchange.RestSpotSupplementary,
@@ -955,7 +955,7 @@ func (bi *Binanceus) GetSubaccountAssets(ctx context.Context, email string) (*Su
 	}
 	params := url.Values{}
 	timestamp := time.Now().UnixMilli()
-	params.Set("timestamp", fmt.Sprintf("%d", timestamp))
+	params.Set("timestamp", strconv.FormatInt(timestamp, 10))
 	params.Set("email", email)
 	//
 	return &resp, bi.SendAuthHTTPRequest(ctx,
@@ -1184,7 +1184,7 @@ func (bi *Binanceus) GetTrades(ctx context.Context, arg *GetTradesParams) ([]Tra
 		params.Set("fromId", strconv.Itoa(int(arg.FromID)))
 	}
 	if arg.Limit > 0 && arg.Limit < 1000 {
-		params.Set("limit", fmt.Sprint(arg.Limit))
+		params.Set("limit", strconv.FormatUint(arg.Limit, 10))
 	} else if arg.Limit > 1000 {
 		params.Set("limit", strconv.Itoa(1000))
 	}
@@ -1244,7 +1244,7 @@ func (bi *Binanceus) CreateNewOCOOrder(ctx context.Context, arg *OCOOrderInputPa
 // GetOCOOrder to retrieve a specific OCO order based on provided optional parameters.
 func (bi *Binanceus) GetOCOOrder(ctx context.Context, arg *GetOCOOrderRequestParams) (*OCOOrderResponse, error) {
 	params := url.Values{}
-	params.Set("timestamp", fmt.Sprint(time.Now().UnixMilli()))
+	params.Set("timestamp", strconv.FormatInt(time.Now().UnixMilli(), 10))
 	switch {
 	case arg.OrderListID != "":
 		params.Set("orderListId", arg.OrderListID)
@@ -1261,23 +1261,23 @@ func (bi *Binanceus) GetOCOOrder(ctx context.Context, arg *GetOCOOrderRequestPar
 // GetAllOCOOrder to retrieve all OCO orders based on provided optional parameters. Please note the maximum limit is 1,000 orders.
 func (bi *Binanceus) GetAllOCOOrder(ctx context.Context, arg *OCOOrdersRequestParams) ([]OCOOrderResponse, error) {
 	params := url.Values{}
-	params.Set("timestamp", fmt.Sprint(time.Now().UnixMilli()))
+	params.Set("timestamp", strconv.FormatInt(time.Now().UnixMilli(), 10))
 	var response []OCOOrderResponse
 	if arg.FromID > 0 {
-		params.Set("fromId", fmt.Sprint(arg.FromID))
+		params.Set("fromId", strconv.FormatUint(arg.FromID, 10))
 	} else {
 		if arg.StartTime.Unix() > 0 && arg.StartTime.Before(arg.EndTime) {
-			params.Set("startTime", fmt.Sprint(arg.StartTime.UnixMilli()))
-			params.Set("endTime", fmt.Sprint(arg.EndTime.UnixMilli()))
+			params.Set("startTime", strconv.FormatInt(arg.StartTime.UnixMilli(), 10))
+			params.Set("endTime", strconv.FormatInt(arg.EndTime.UnixMilli(), 10))
 		} else if arg.StartTime.Unix() > 0 {
-			params.Set("startTime", fmt.Sprint(arg.StartTime.UnixMilli()))
+			params.Set("startTime", strconv.FormatInt(arg.StartTime.UnixMilli(), 10))
 		}
 	}
 	if arg.Limit > 0 {
-		params.Set("limit", fmt.Sprint(arg.Limit))
+		params.Set("limit", strconv.FormatUint(arg.Limit, 10))
 	}
 	if arg.RecvWindow > 0 {
-		params.Set("recvWindow", fmt.Sprint(arg.RecvWindow))
+		params.Set("recvWindow", strconv.FormatUint(arg.RecvWindow, 10))
 	}
 	return response, bi.SendAuthHTTPRequest(ctx, exchange.RestSpotSupplementary,
 		http.MethodGet, ocoAllOrderList,
@@ -1286,11 +1286,11 @@ func (bi *Binanceus) GetAllOCOOrder(ctx context.Context, arg *OCOOrdersRequestPa
 }

 // GetOpenOCOOrders to query open OCO orders.
-func (bi *Binanceus) GetOpenOCOOrders(ctx context.Context, recvWindow uint) ([]OCOOrderResponse, error) {
+func (bi *Binanceus) GetOpenOCOOrders(ctx context.Context, recvWindow uint64) ([]OCOOrderResponse, error) {
 	params := url.Values{}
-	params.Set("timestamp", fmt.Sprint(time.Now().UnixMilli()))
+	params.Set("timestamp", strconv.FormatInt(time.Now().UnixMilli(), 10))
 	if recvWindow > 0 {
-		params.Set("recvWindow", fmt.Sprint(recvWindow))
+		params.Set("recvWindow", strconv.FormatUint(recvWindow, 10))
 	} else {
 		params.Set("recvWindow", "30000")
 	}
@@ -1304,7 +1304,7 @@ func (bi *Binanceus) GetOpenOCOOrders(ctx context.Context, recvWindow uint) ([]O
 func (bi *Binanceus) CancelOCOOrder(ctx context.Context, arg *OCOOrdersDeleteRequestParams) (*OCOFullOrderResponse, error) {
 	var response OCOFullOrderResponse
 	params := url.Values{}
-	params.Set("timestamp", fmt.Sprint(time.Now().UnixMilli()))
+	params.Set("timestamp", strconv.FormatInt(time.Now().UnixMilli(), 10))
 	switch {
 	case arg.OrderListID > 0:
 		params.Set("orderListId", strconv.Itoa(int(arg.OrderListID)))
@@ -1314,7 +1314,7 @@ func (bi *Binanceus) CancelOCOOrder(ctx context.Context, arg *OCOOrdersDeleteReq
 		return nil, errIncompleteArguments
 	}
 	if arg.RecvWindow > 0 {
-		params.Set("recvWindow", fmt.Sprint(arg.RecvWindow))
+		params.Set("recvWindow", strconv.FormatUint(arg.RecvWindow, 10))
 	}
 	return &response, bi.SendAuthHTTPRequest(ctx, exchange.RestSpotSupplementary,
 		http.MethodGet, ocoOrderList,
@@ -1389,7 +1389,7 @@ func (bi *Binanceus) GetOTCTradeOrder(ctx context.Context, orderID uint64) (*OTC
 	}
 	orderIDStr := strconv.FormatUint(orderID, 10)
 	params.Set("orderId", orderIDStr)
-	params.Set("timestamp", fmt.Sprint(time.Now().UnixMilli()))
+	params.Set("timestamp", strconv.FormatInt(time.Now().UnixMilli(), 10))
 	path := otcTradeOrders + orderIDStr
 	return &response, bi.SendAuthHTTPRequest(ctx,
 		exchange.RestSpotSupplementary,
@@ -1679,16 +1679,16 @@ func (bi *Binanceus) DepositHistory(ctx context.Context, c currency.Code, status
 func (bi *Binanceus) FiatDepositHistory(ctx context.Context, arg *FiatWithdrawalRequestParams) (FiatAssetsHistory, error) {
 	params := url.Values{}
 	if !(arg.EndTime.IsZero()) && !(arg.EndTime.Before(time.Now())) {
-		params.Set("endTime", fmt.Sprint(arg.EndTime.UnixMilli()))
+		params.Set("endTime", strconv.FormatInt(arg.EndTime.UnixMilli(), 10))
 	}
 	if !(arg.StartTime.IsZero()) && !(arg.StartTime.After(time.Now())) {
-		params.Set("startTime", fmt.Sprint(arg.StartTime.UnixMilli()))
+		params.Set("startTime", strconv.FormatInt(arg.StartTime.UnixMilli(), 10))
 	}
 	if arg.FiatCurrency != "" {
 		params.Set("fiatCurrency", arg.FiatCurrency)
 	}
 	if arg.Offset > 0 {
-		params.Set("offset", fmt.Sprint(arg.Offset))
+		params.Set("offset", strconv.FormatInt(arg.Offset, 10))
 	}
 	if arg.PaymentChannel != "" {
 		params.Set("paymentChannel", arg.PaymentChannel)
@@ -1696,7 +1696,7 @@ func (bi *Binanceus) FiatDepositHistory(ctx context.Context, arg *FiatWithdrawal
 	if arg.PaymentMethod != "" {
 		params.Set("paymentMethod", arg.PaymentMethod)
 	}
-	params.Set("timestamp", fmt.Sprint(time.Now().UnixMilli()))
+	params.Set("timestamp", strconv.FormatInt(time.Now().UnixMilli(), 10))
 	var response FiatAssetsHistory
 	return response, bi.SendAuthHTTPRequest(ctx,
 		exchange.RestSpotSupplementary, http.MethodGet,
--- a/exchanges/binanceus/binanceus_types.go
+++ b/exchanges/binanceus/binanceus_types.go
@@ -300,8 +300,8 @@ type AccountStatusResponse struct {
 // TradeStatus represents trade status and holds list of trade status indicator Item instances.
 type TradeStatus struct {
 	IsLocked           bool                                  `json:"isLocked"`
-	PlannedRecoverTime uint                                  `json:"plannedRecoverTime"`
-	TriggerCondition   map[string]uint                       `json:"triggerCondition"`
+	PlannedRecoverTime uint64                                `json:"plannedRecoverTime"`
+	TriggerCondition   map[string]uint64                     `json:"triggerCondition"`
 	Indicators         map[string]TradingStatusIndicatorItem `json:"indicators"`
 	UpdateTime         time.Time                             `json:"updateTime"`
 }
@@ -340,7 +340,7 @@ type AssetHistory struct {
 // including for staking, referrals and airdrops etc.
 type AssetDistributionHistories struct {
 	Rows  []AssetHistory `json:"rows"`
-	Total uint           `json:"total"`
+	Total uint64         `json:"total"`
 }

 // SubAccount  holds a single sub account instance in a Binance US account.
@@ -359,7 +359,7 @@ type TransferHistory struct {
 	From      string    `json:"from"`
 	To        string    `json:"to"`
 	Asset     string    `json:"asset"`
-	Qty       uint      `json:"qty,string"`
+	Qty       uint64    `json:"qty,string"`
 	TimeStamp time.Time `json:"time"`
 }

@@ -398,9 +398,9 @@ type SubAccountAssets struct {
 type OrderRateLimit struct {
 	RateLimitType string `json:"rateLimitType"`
 	Interval      string `json:"interval"`
-	IntervalNum   uint   `json:"intervalNum"`
-	Limit         uint   `json:"limit"`
-	Count         uint   `json:"count"`
+	IntervalNum   uint64 `json:"intervalNum"`
+	Limit         uint64 `json:"limit"`
+	Count         uint64 `json:"count"`
 }

 // RequestParamsOrderType trade order type
@@ -504,7 +504,7 @@ type OrderRequestParams struct {
 	Symbol            string `json:"symbol"` // REQUIRED
 	OrderID           uint64 `json:"orderId"`
 	OrigClientOrderID string `json:"origClientOrderId"`
-	recvWindow        uint
+	recvWindow        uint64
 }

 // CancelOrderRequestParams this struct will be used as a parameter for
@@ -514,7 +514,7 @@ type CancelOrderRequestParams struct {
 	OrderID               string
 	ClientSuppliedOrderID string
 	NewClientOrderID      string
-	RecvWindow            uint
+	RecvWindow            uint64
 }

 // GetTradesParams  request param to get the trade history
@@ -524,8 +524,8 @@ type GetTradesParams struct {
 	StartTime  *time.Time `json:"startTime"`
 	EndTime    *time.Time `json:"endTime"`
 	FromID     uint64     `json:"fromId"`
-	Limit      uint       `json:"limit"`
-	RecvWindow uint       `json:"recvWindow"`
+	Limit      uint64     `json:"limit"`
+	RecvWindow uint64     `json:"recvWindow"`
 }

 // Trade this struct represents a trade response.
@@ -599,8 +599,8 @@ type OCOOrdersRequestParams struct {
 	FromID     uint64
 	StartTime  time.Time
 	EndTime    time.Time
-	Limit      uint
-	RecvWindow uint
+	Limit      uint64
+	RecvWindow uint64
 }

 // OCOOrdersDeleteRequestParams holds the params to delete a new order
@@ -609,7 +609,7 @@ type OCOOrdersDeleteRequestParams struct {
 	OrderListID       uint64
 	ListClientOrderID string
 	NewClientOrderID  string
-	RecvWindow        uint
+	RecvWindow        uint64
 }

 // OTC endpoints
@@ -1076,7 +1076,7 @@ type OCBSOrderRequestParams struct {
 	OrderID   string
 	StartTime time.Time
 	EndTime   time.Time
-	Limit     uint
+	Limit     uint64
 }

 // OCBSTradeOrdersResponse holds the quantity and list of OCBS Orders.
--- a/exchanges/binanceus/binanceus_wrapper.go
+++ b/exchanges/binanceus/binanceus_wrapper.go
@@ -471,7 +471,7 @@ func (bi *Binanceus) GetWithdrawalsHistory(ctx context.Context, c currency.Code,
 			return nil, err
 		}
 		resp[i] = exchange.WithdrawalHistory{
-			Status:          fmt.Sprint(withdrawals[i].Status),
+			Status:          strconv.FormatInt(withdrawals[i].Status, 10),
 			TransferID:      withdrawals[i].ID,
 			Currency:        withdrawals[i].Coin,
 			Amount:          withdrawals[i].Amount,
@@ -501,7 +501,7 @@ func (bi *Binanceus) GetRecentTrades(ctx context.Context, p currency.Pair, asset
 	resp := make([]trade.Data, len(tradeData))
 	for i := range tradeData {
 		resp[i] = trade.Data{
-			TID:          fmt.Sprint(tradeData[i].ID),
+			TID:          strconv.FormatInt(tradeData[i].ID, 10),
 			Exchange:     bi.Name,
 			AssetType:    assetType,
 			CurrencyPair: p,