CI/build: Update Go version, linters and fix minor issues (#1473)

* CI/build: Update Go version, linters and fix minor issues

* Bump golangci-lint to v1.56.1

* BinanceUS: Make uint usage consistent

* Throw blank identifiers into the trash
This commit is contained in:
Adrian Gallagher
2024-02-14 11:02:06 +11:00
committed by GitHub
parent 9ff502bac2
commit 08da42ddb7
79 changed files with 364 additions and 374 deletions

View File

@@ -99,7 +99,6 @@ func TestAudit(t *testing.T) {
}
}
//nolint:gocritic // Only used as a testing helper function in this package
func writeAudit(t *testing.T) {
t.Helper()
var wg sync.WaitGroup
@@ -117,7 +116,6 @@ func writeAudit(t *testing.T) {
wg.Wait()
}
//nolint:gocritic // Only used as a testing helper function in this package
func readHelper(t *testing.T) {
t.Helper()

View File

@@ -4,6 +4,7 @@ import (
"fmt"
"log"
"os"
"strconv"
"testing"
"time"
@@ -120,7 +121,7 @@ func tradeSQLTester(t *testing.T) {
Price: float64(i * (i + 3)),
Amount: float64(i * (i + 2)),
Side: order.Buy.String(),
TID: fmt.Sprintf("%v", i),
TID: strconv.Itoa(i),
})
}
err := Insert(trades...)
@@ -140,7 +141,7 @@ func tradeSQLTester(t *testing.T) {
Price: float64(i * (i + 3)),
Amount: float64(i * (i + 2)),
Side: order.Buy.String(),
TID: fmt.Sprintf("%v", i),
TID: strconv.Itoa(i),
})
}
err = Insert(trades2...)

View File

@@ -154,7 +154,6 @@ func seedWithdrawData() {
}
}
//nolint:gocritic // Only used as a testing helper function in this package
func withdrawHelper(t *testing.T) {
t.Helper()
seedWithdrawData()