From 0676c78becd91361a4e2aab99d2c9e5c024f6c00 Mon Sep 17 00:00:00 2001 From: Ryan O'Hara-Reid Date: Fri, 3 May 2024 10:29:26 +1000 Subject: [PATCH] btcmarkets: remove trailing slash on markets/ticker strings and update endpoint paths (#1530) * btcmarkets: fix endpoint issue * Update exchanges/btcmarkets/btcmarkets.go Co-authored-by: Adrian Gallagher --------- Co-authored-by: shazbert Co-authored-by: Adrian Gallagher --- exchanges/btcmarkets/btcmarkets.go | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/exchanges/btcmarkets/btcmarkets.go b/exchanges/btcmarkets/btcmarkets.go index 7ca254cd..9616d404 100644 --- a/exchanges/btcmarkets/btcmarkets.go +++ b/exchanges/btcmarkets/btcmarkets.go @@ -31,8 +31,8 @@ const ( btcMarketsAPIVersion = "/v3" // UnAuthenticated EPs - btcMarketsAllMarkets = "/markets/" - btcMarketsGetTicker = "/ticker/" + btcMarketsAllMarkets = "/markets" + btcMarketsGetTicker = "/ticker" btcMarketsGetTrades = "/trades?" btcMarketOrderBook = "/orderbook?" btcMarketsCandles = "/candles?" @@ -110,7 +110,7 @@ func (b *BTCMarkets) GetMarkets(ctx context.Context) ([]Market, error) { // symbol - example "btc" or "ltc" func (b *BTCMarkets) GetTicker(ctx context.Context, marketID string) (Ticker, error) { var tick Ticker - return tick, b.SendHTTPRequest(ctx, btcMarketsUnauthPath+marketID+btcMarketsGetTicker, &tick) + return tick, b.SendHTTPRequest(ctx, btcMarketsUnauthPath+"/"+marketID+btcMarketsGetTicker, &tick) } // GetTrades returns executed trades on the exchange @@ -129,7 +129,7 @@ func (b *BTCMarkets) GetTrades(ctx context.Context, marketID string, before, aft if limit > 0 { params.Set("limit", strconv.FormatInt(limit, 10)) } - return trades, b.SendHTTPRequest(ctx, btcMarketsUnauthPath+marketID+btcMarketsGetTrades+params.Encode(), + return trades, b.SendHTTPRequest(ctx, btcMarketsUnauthPath+"/"+marketID+btcMarketsGetTrades+params.Encode(), &trades) } @@ -144,7 +144,7 @@ func (b *BTCMarkets) GetOrderbook(ctx context.Context, marketID string, level in params.Set("level", strconv.FormatInt(level, 10)) } var temp tempOrderbook - err := b.SendHTTPRequest(ctx, btcMarketsUnauthPath+marketID+btcMarketOrderBook+params.Encode(), + err := b.SendHTTPRequest(ctx, btcMarketsUnauthPath+"/"+marketID+btcMarketOrderBook+params.Encode(), &temp) if err != nil { return nil, err @@ -214,7 +214,7 @@ func (b *BTCMarkets) GetMarketCandles(ctx context.Context, marketID, timeWindow if limit > 0 { params.Set("limit", strconv.FormatInt(limit, 10)) } - return out, b.SendHTTPRequest(ctx, btcMarketsUnauthPath+marketID+btcMarketsCandles+params.Encode(), &out) + return out, b.SendHTTPRequest(ctx, btcMarketsUnauthPath+"/"+marketID+btcMarketsCandles+params.Encode(), &out) } // GetTickers gets multiple tickers @@ -224,7 +224,7 @@ func (b *BTCMarkets) GetTickers(ctx context.Context, marketIDs currency.Pairs) ( for x := range marketIDs { params.Add("marketId", marketIDs[x].String()) } - return tickers, b.SendHTTPRequest(ctx, btcMarketsUnauthPath+btcMarketsTickers+params.Encode(), + return tickers, b.SendHTTPRequest(ctx, btcMarketsUnauthPath+"/"+btcMarketsTickers+params.Encode(), &tickers) } @@ -235,7 +235,7 @@ func (b *BTCMarkets) GetMultipleOrderbooks(ctx context.Context, marketIDs []stri for x := range marketIDs { params.Add("marketId", marketIDs[x]) } - err := b.SendHTTPRequest(ctx, btcMarketsUnauthPath+btcMarketsMultipleOrderbooks+params.Encode(), + err := b.SendHTTPRequest(ctx, btcMarketsUnauthPath+"/"+btcMarketsMultipleOrderbooks+params.Encode(), &temp) if err != nil { return nil, err