d0zingcat/claude-code
1
0
Fork 0
mirror of https://github.com/instructkr/claude-code.git synced 2026-05-28 08:26:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(#706): skills show <name> returns error+exit1 when skill not found; classify_error_kind covers skill_not_found from prose message

Browse Source
This commit is contained in:
YeonGyu-Kim
2026-05-26 00:04:39 +09:00
parent f84799c8ef
commit dedad14ae4
3 changed files with 29 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
rust/crates/commands/src/lib.rs
View File

@@ -2485,6 +2485,17 @@ pub fn handle_skills_slash_command_json(args: Option<&str>, cwd: &Path) -> std::
.into_iter()
.filter(|s| s.name.to_lowercase() == name)
.collect();
// #706: return typed error when named skill is not found instead of silent empty list
if matched.is_empty() {
return Ok(json!({
"kind": "skills",
"action": "show",
"status": "error",
"error_kind": "skill_not_found",
"message": format!("skill '{}' not found", name),
"requested": name,
}));
}
Ok(render_skills_report_json(&matched))
}
Some("install") => Ok(render_skills_usage_json(Some("install"))),

21
rust/crates/rusty-claude-cli/src/main.rs
View File

@@ -304,7 +304,9 @@ fn classify_error_kind(message: &str) -> &'static str {
"unknown_agents_subcommand"
} else if message.contains("is not installed") {
"plugin_not_found"
} else if message.contains("skill source") && message.contains("not found") {
} else if (message.contains("skill source") && message.contains("not found"))
|| message.starts_with("skill '")
{
"skill_not_found"
} else if message.contains("Unsupported config section") {
"unsupported_config_section"
@@ -5940,10 +5942,19 @@ impl LiveCli {
let cwd = env::current_dir()?;
match output_format {
CliOutputFormat::Text => println!("{}", handle_skills_slash_command(args, &cwd)?),
CliOutputFormat::Json => println!(
"{}",
serde_json::to_string_pretty(&handle_skills_slash_command_json(args, &cwd)?)?
),
CliOutputFormat::Json => {
let result = handle_skills_slash_command_json(args, &cwd)?;
let is_error = result.get("status").and_then(|v| v.as_str()) == Some("error");
println!("{}", serde_json::to_string_pretty(&result)?);
if is_error {
return Err(result
.get("message")
.and_then(|v| v.as_str())
.unwrap_or("skills command failed")
.to_string()
.into());
}
}
}
Ok(())
}